[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: Remove unused zero_ethadd
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: Remove unused zero_ethaddr[] variable |
Date: |
Thu, 29 May 2014 14:01:57 +0100 |
On 29 May 2014 13:52, Stefan Weil <address@hidden> wrote:
> I can add some more:
>
> * Missing 'static' attributes for local variables and functions
Those seem worth fixing.
> * Use of 0 instead of NULL for pointers (do we want to fix those?)
I wouldn't bother personally.
There's also still a tail of coverity issues.
thanks
-- PMM