qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2] tests/tcg: Fix compilation of test_path


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH v2] tests/tcg: Fix compilation of test_path
Date: Sat, 03 May 2014 12:39:33 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0

29.04.2014 15:09, Peter Maydell wrote:
> The test_path binary is (unlike the other test binaries in tests/tcg)
> actually intended to be compiled with the same compiler used to build
> the main QEMU executables. It actually #includes a number of the
> QEMU source files in an attempt to unit-test the util/path.c functions,
> and so if it is not compiled with the same compiler used by configure
> to set CONFIG_ settings then it is liable to fail to build.
> Fix the makefile to build it with the default C compiler rules, not
> CC_I386, and fix the test itself not to include a lot of unnecessary
> trace related source files which cause the build to fail if the trace
> backend is anything other than 'simple'.

Yay, ACK!

Applies to -trivial, thank you!

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]