[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bi
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit |
Date: |
Tue, 8 Apr 2014 11:04:05 +0400 |
From: Peter Maydell <address@hidden>
Add U suffix to avoid shifting left into the sign bit, which
is undefined behaviour.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/ide/ahci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index bfe633f..50327ff 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -438,9 +438,9 @@ static void check_cmd(AHCIState *s, int port)
if ((pr->cmd & PORT_CMD_START) && pr->cmd_issue) {
for (slot = 0; (slot < 32) && pr->cmd_issue; slot++) {
- if ((pr->cmd_issue & (1 << slot)) &&
+ if ((pr->cmd_issue & (1U << slot)) &&
!handle_cmd(s, port, slot)) {
- pr->cmd_issue &= ~(1 << slot);
+ pr->cmd_issue &= ~(1U << slot);
}
}
}
--
1.7.10.4
- [Qemu-trivial] [PULL for-2.0 00/11] Trivial patches for 2014-04-08, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit,
Michael Tokarev <=
- [Qemu-trivial] [PULL 04/11] net: Report error when device / hub combo is not found., Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 02/11] qga: trivial fix for unclear documentation of guest-set-time, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 07/11] xbzrle.c: Avoid undefined behaviour with signed arithmetic, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 03/11] configure: Fix indentation of help for --enable/disable-debug-info, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 09/11] configure: Remove redundant message for -Werror, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 11/11] Fix grammar in comment, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 08/11] scripts: add sample model file for Coverity Scan, Michael Tokarev, 2014/04/08