Re: [Qemu-trivial] [Qemu-devel] [PATCH v4] scripts: add sample model file for Coverity Scan

[Dr. David Alan Gilbert]

* Michael Tokarev (address@hidden) wrote:
> 26.03.2014 15:45, Paolo Bonzini wrote:
> > This is the model file that is being used for the QEMU project's scans
> > on scan.coverity.com.  It fixed about 30 false positives (10% of the
> > total) and exposed about 60 new memory leaks.
> > 
> > The file is not automatically used; changes to it must be propagated
> > to the website manually by an admin (right now Markus, Peter and me
> > are admins).
> 
> While we don't have issues with the model itself, but really wonder if we
> should keep this file inside qemu sources.  It isn't used in there, as
> explicitly stated above, and maybe it is easier to maintain it "closer"
> to the website?

Given that the model file describes semantics of functions in the codebase
it needs to be kept consistent with the version of the code.
Hence it needs to be version controlled with the code, hence the best place
is inside the qemu sources.

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK