[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemLis
From: |
Alexander Graf |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function |
Date: |
Wed, 2 Apr 2014 13:32:29 +0200 |
> Am 02.04.2014 um 12:53 schrieb Andreas Färber <address@hidden>:
>
> Am 02.04.2014 10:54, schrieb Alexander Graf:
>>
>> On 24.03.14 15:25, Andreas Färber wrote:
>>> Am 23.03.2014 10:28, schrieb Prasad Joshi:
>>>> Signed-off-by: Prasad Joshi <address@hidden>
>>>> ---
>>>> hw/intc/openpic_kvm.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> Thanks for spotting this, applied to ppc-next (w/ typo fix in subject):
>>> https://github.com/afaerber/qemu-cpu/commits/ppc-next
>>
>> This patch breaks the e500 platform target.
>
> Ouch. I had specifically tested build and -M pseries on PowerKVM but
> obviously did not for e500.
Yeah, this file is only used on e500 with kvm enabled. No worries, things
worked out well :).
>
> Means it was theoretically broken from the start then, if you compare my
> extended commit message:
>
> http://git.qemu.org/?p=qemu.git;a=commit;h=6f1834a2baa2f2688efaa7756d000876c7898d13
Well, it definitely worked before, though most likely by chance ;).
Alex
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg