[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] misc: Spelling and grammar fi
From: |
Don Koch |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments |
Date: |
Fri, 11 Oct 2013 16:51:19 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 10/11/2013 04:08 PM, Stefan Weil wrote:
> Am 11.10.2013 22:03, schrieb Don Koch:
>> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>>> * it's -> its
>>> * grammar fix in ui/vnc-enc-zywrle.h
>>>
>>> Signed-off-by: Stefan Weil <address@hidden>
>>> ---
>>>
>>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>>>
>>> v3:
>>> Don't try to improve a strange sentence in the same context ("Of cause
>>> [...]").
>>>
>>> qapi-schema.json | 2 +-
>>> slirp/if.c | 2 +-
>>> ui/vnc-enc-zywrle.h | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/qapi-schema.json b/qapi-schema.json
>>> index 60f3fd1..a003aa1 100644
>>> --- a/qapi-schema.json
>>> +++ b/qapi-schema.json
>>> @@ -1914,7 +1914,7 @@
>>> #
>>> # Since: 0.14.0
>>> #
>>> -# Notes: This command only exists as a stop-gap. It's use is highly
>>> +# Notes: This command only exists as a stop-gap. Its use is highly
>>> # discouraged. The semantics of this command are not guaranteed.
>>> #
>>> # Known limitations:
>>> diff --git a/slirp/if.c b/slirp/if.c
>>> index 87ca8a5..fb7acf8 100644
>>> --- a/slirp/if.c
>>> +++ b/slirp/if.c
>>> @@ -142,7 +142,7 @@ diddit:
>>>
>>> /*
>>> * Send a packet
>>> - * We choose a packet based on it's position in the output queues;
>>> + * We choose a packet based on its position in the output queues;
>>> * If there are packets on the fastq, they are sent FIFO, before
>>> * everything else. Otherwise we choose the first packet from the
>>> * batchq and send it. the next packet chosen will be from the session
>>> diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
>>> index 1ff40b1..d436d58 100644
>>> --- a/ui/vnc-enc-zywrle.h
>>> +++ b/ui/vnc-enc-zywrle.h
>>> @@ -305,7 +305,7 @@ static inline void harr(int8_t *px0, int8_t *px1)
>>> |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
>>>
>>> In this method, H/L and X0/X1 is always same position.
>>> - This lead us to more speed and less memory.
>>> + This leads us to more speed and less memory.
>>> Of cause, the result of both method is quite same
>>> because it's only difference that coefficient position.
>>> */
>>>
>> Since you're in the neighborhood, this paragraph needs more fixes:
>>
>> In this method, H/L and X0/X1 is always in the same position.
>
> Shouldn't it be "are always"? :-)
Yes. I got swamped by the other typos. :-)
>
>> This leads us to more speed and less memory.
>> Of course, the result of both methods is the same
>> because the only difference is the coefficient position.
>>
>> Thanks,
>> -d
>
> Maybe. Please let us fix that in a later patch.\
Works for me.
> See also the previous discussion
> (http://patchwork.ozlabs.org/patch/257416/).
I had unfortunately deleted that thread when I saw there was an update.
*sigh*
> Regards,
> Stefan
Reviewed-By: Don Koch <address@hidden>
-d
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments, Peter Maydell, 2013/10/11
Re: [Qemu-trivial] [PATCH v3] misc: Spelling and grammar fixes in comments, Michael Tokarev, 2013/10/26