[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] ppc: fixed RAM initialization bug in hw/ppc4x
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] ppc: fixed RAM initialization bug in hw/ppc4xx_devs.c, can now use memory larger than 256MB in bamboo PPC machines |
Date: |
Thu, 21 Feb 2013 10:36:21 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 20, 2013 at 09:36:09PM -0500, Alin Tomescu wrote:
> I hope this is the right way of submitting QEMU patches.
>
> I was trying to launch a PowerPC "bamboo" machine with more than 256MB of RAM
> with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but
> QEMU
> would just hang. However, when I used -m 256, the machine would boot.
>
> I looked through the code in hw/ and it seems there is an error when the
> RAM memory is setup (if my understanding is correct).
>
> After patching it, the machine launched and booted successfully with 512MB of
> RAM.
>
> Signed-off-by: Alin Tomescu <address@hidden>
> ---
> hw/ppc4xx_devs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I shortened the commit message and dropped the first line of commit
description ("I hope this is the right way of submitting QEMU
patches.").
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan