[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean up
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes |
Date: |
Thu, 22 Mar 2012 14:28:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-03-22 01:05, Paolo Bonzini wrote:
> Il 21/03/2012 22:02, Peter Portante ha scritto:
>> Hi Folks,
>>
>> Please forgive me if you find these changes are annoying, as I am trying to
>> learn the ropes of patch submission with git ahead of making a real patch.
>>
>> While working on the code, I found that scripts/checkpatch.pl will flag lines
>> that I am changing as not adhereing to the codeing standard due to
>> pre-existing coding violations. So I figured I could learn a bit about how to
>> submit patches by fixing these files I will be touching before submitting the
>> code changes.
>
> I think slirp is a mess and it's not worth doing this kind of sweeping
> change. Just ignore checkpatch output for slirp.
In fact, I could imagine accepting slirp cleanups provided they come in
palatable pieces and validate that the binary output is unchanged. It's
really a pain changing something in slirp having to use a totally
inconsistent style just to keep the code slightly readable.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Peter Portante, 2012/03/21
- [Qemu-trivial] [PATCH 4/4] Yet another missed use of tabs., Peter Portante, 2012/03/21
- [Qemu-trivial] [PATCH 3/4] And some final work to complete the coding style upgrade, missed by the previous commit., Peter Portante, 2012/03/21
- [Qemu-trivial] [PATCH 1/4] More whitespace cleanup in preparation for future commits., Peter Portante, 2012/03/21
- [Qemu-trivial] [PATCH 2/4] More work to fix up the formatting and the whitespace of this module to conform to the coding standard., Peter Portante, 2012/03/21
- Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Paolo Bonzini, 2012/03/21
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Peter Maydell, 2012/03/22