|
From: | Anthony Liguori |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device |
Date: | Wed, 21 Mar 2012 11:33:21 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 |
On 03/21/2012 11:26 AM, Anthony Liguori wrote:
On 03/21/2012 11:11 AM, Michael S. Tsirkin wrote:Frankly I don't see value in making it visible to the user, at all. We are just triggering windows reactivations without any user benefit. Why not return a fixed value there to avoid that?I don't see a problem making it fixed for 1.1, but for 1.0 and older, we should expose what we were supposed to expose. We need to fix the bug first, then we can change the behavior.
In some cases, like USB, we really do want to expose a version, but we should probably only expose the major version, for instance, QEMU 1.x or 2.x. This would only be exposed by the appropriate machine types.
Regards, Anthony Liguori
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |