Re: [Qemu-trivial] [Qemu-devel] [PATCH] scsi-bus: use DO_UPCAST.

[Markus Armbruster]

Zhi Yong Wu <address@hidden> writes:

> Signed-off-by: Zhi Yong Wu <address@hidden>
> ---
>  hw/scsi-bus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index ad6a730..f6c416e 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -712,7 +712,7 @@ void scsi_device_purge_requests(SCSIDevice *sdev)
>  
>  static char *scsibus_get_fw_dev_path(DeviceState *dev)
>  {
> -    SCSIDevice *d = (SCSIDevice*)dev;
> +    SCSIDevice *d = DO_UPCAST(SCSIDevice, qdev, dev);
>      SCSIBus *bus = scsi_bus_from_device(d);
>      char path[100];
>      int i;

Reviewed-by: Markus Armbruster <address@hidden>