qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert "accel/tcg: Init TCG cflags in vCPU thread handler"


From: Richard Henderson
Subject: Re: [PATCH] Revert "accel/tcg: Init TCG cflags in vCPU thread handler"
Date: Sat, 22 Oct 2022 20:03:46 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 10/22/22 02:34, Peter Maydell wrote:
Commit a82fd5a4ec24d was intended to be a code cleanup, but
unfortunately it has a bug. It moves the initialization of the
TCG cflags from the "start a new vcpu" function to the
thread handler; this is fine when each vcpu has its own thread,
but when we are doing round-robin of vcpus on a single thread
we end up only initializing the cflags for CPU 0, not for any
of the others.

The most obvious effect of this bug is that running in icount
mode with more than one CPU is broken; typically the guest
hangs shortly after it brings up the secondary CPUs.

This reverts commit a82fd5a4ec24d923ff1e6da128c0fd4a74079d99.

Cc:qemu-stable@nongnu.org
Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  accel/tcg/tcg-accel-ops-mttcg.c | 5 +++--
  accel/tcg/tcg-accel-ops-rr.c    | 7 ++++---
  2 files changed, 7 insertions(+), 5 deletions(-)

Thanks, queued to tcg-next.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]