Re: [PATCH v2 08/13] target/ppc: Merge helper_{dcbz,dcbzep}

[Richard Henderson]

On 7/10/24 05:20, BALATON Zoltan wrote:
> On Tue, 9 Jul 2024, Richard Henderson wrote:
> > Merge the two and pass the mmu_idx directly from translation.
> > Swap the argument order in dcbz_common to avoid extra swaps.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> > target/ppc/helper.h     |  3 +--
> > target/ppc/mem_helper.c | 14 ++++----------
> > target/ppc/translate.c  |  4 ++--
> > 3 files changed, 7 insertions(+), 14 deletions(-)
> >
> > diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> > index afc56855ff..4fa089cbf9 100644
> > --- a/target/ppc/helper.h
> > +++ b/target/ppc/helper.h
> > @@ -46,8 +46,7 @@ DEF_HELPER_FLAGS_3(stmw, TCG_CALL_NO_WG, void, env, tl, i32)
> > DEF_HELPER_4(lsw, void, env, tl, i32, i32)
> > DEF_HELPER_5(lswx, void, env, tl, i32, i32, i32)
> > DEF_HELPER_FLAGS_4(stsw, TCG_CALL_NO_WG, void, env, tl, i32, i32)
> > -DEF_HELPER_FLAGS_2(dcbz, TCG_CALL_NO_WG, void, env, tl)
> > -DEF_HELPER_FLAGS_2(dcbzep, TCG_CALL_NO_WG, void, env, tl)
> > +DEF_HELPER_FLAGS_3(dcbz, TCG_CALL_NO_WG, void, env, tl, int)
> > #ifdef TARGET_PPC64
> > DEF_HELPER_FLAGS_2(dcbzl, TCG_CALL_NO_WG, void, env, tl)
>
> Why only dcbz but not dcbzl as well to make them uniform?

Because dcbzl has extra logic, so doesn't get merged.
The expansion of ppc_env_mmu_index() is not large, so there's no gain in 
passing it in.

The point was to eliminate duplication where it was easy.


r~