Re: [PATCH v2 06/14] hw/i386: convert 'i440fx' machine definitions to use new macros

[Philippe Mathieu-Daudé]

On 20/6/24 18:57, Daniel P. Berrangé wrote:
> This changes the DEFINE_I440FX_MACHINE macro to use the common
> helpers for constructing versioned symbol names and strings,
> bringing greater consistency across targets.
>
> The added benefit is that it avoids the need to repeat the
> version number thrice in three different formats in the calls
> to DEFINE_I440FX_MACHINE.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   hw/i386/pc_piix.c    | 219 +++++++++++++++++++------------------------
>   include/hw/i386/pc.h |  26 +++++
>   2 files changed, 122 insertions(+), 123 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>