[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/4] hw/s390x: Deprecate the HMP 'dump_skeys' command
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 3/4] hw/s390x: Deprecate the HMP 'dump_skeys' command |
Date: |
Thu, 30 May 2024 09:45:43 +0200 |
Prefer 'dump_s390_skeys' which is target agnostic.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/s390x/s390-skeys.c | 2 ++
hmp-commands.hx | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index e7dab52a6e..12ec8a808e 100644
--- a/hw/s390x/s390-skeys.c
+++ b/hw/s390x/s390-skeys.c
@@ -120,6 +120,8 @@ void hmp_dump_s390_skeys(Monitor *mon, const QDict *qdict)
void hmp_dump_skeys(Monitor *mon, const QDict *qdict)
{
+ monitor_printf(mon, "This command is deprecated"
+ " (replaced by 'dump-s390-skeys')\n");
hmp_dump_s390_skeys(mon, qdict);
}
diff --git a/hmp-commands.hx b/hmp-commands.hx
index c12e2c2bd9..04ae897134 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1138,14 +1138,14 @@ ERST
.name = "dump-skeys",
.args_type = "filename:F",
.params = "",
- .help = "Save guest storage keys into file 'filename'.\n",
+ .help = "deprecated synonym for dump-s390-skeys.",
.cmd = hmp_dump_skeys,
},
#endif
SRST
``dump-skeys`` *filename*
- Save guest storage keys to a file.
+ This is a deprecated synonym for the dump-s390-skeys command.
ERST
#if defined(TARGET_S390X)
--
2.41.0
- [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate, Philippe Mathieu-Daudé, 2024/05/30
- [PATCH 1/4] hw/s390x: Introduce the @dump-s390-skeys QMP command, Philippe Mathieu-Daudé, 2024/05/30
- [PATCH 2/4] hw/s390x: Introduce the 'dump_s390_skeys' HMP command, Philippe Mathieu-Daudé, 2024/05/30
- [PATCH 3/4] hw/s390x: Deprecate the HMP 'dump_skeys' command,
Philippe Mathieu-Daudé <=
- [PATCH 4/4] hw/s390x: Deprecate the QMP @dump-skeys command, Philippe Mathieu-Daudé, 2024/05/30
- Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate, Anton Johansson, 2024/05/30
- Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate, Thomas Huth, 2024/05/31