[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared
From: |
Nicholas Piggin |
Subject: |
[RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared |
Date: |
Sat, 25 May 2024 23:12:40 +1000 |
This was said to be broken on aarch64, but if it works on others,
let's try enable it. It's already starting to bitrot...
Cc: Yury Kotov <yury-kotov@yandex-team.ru>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/qtest/migration-test.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 7987faaded..2bcdc33b7c 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1862,14 +1862,15 @@ static void
test_precopy_unix_tls_x509_override_host(void)
#endif /* CONFIG_TASN1 */
#endif /* CONFIG_GNUTLS */
-#if 0
-/* Currently upset on aarch64 TCG */
static void test_ignore_shared(void)
{
g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
QTestState *from, *to;
+ MigrateStart args = {
+ .use_shmem = true,
+ };
- if (test_migrate_start(&from, &to, uri, false, true, NULL, NULL)) {
+ if (test_migrate_start(&from, &to, uri, &args)) {
return;
}
@@ -1898,7 +1899,6 @@ static void test_ignore_shared(void)
test_migrate_end(from, to, true);
}
-#endif
static void *
test_migrate_xbzrle_start(QTestState *from,
@@ -3537,7 +3537,10 @@ int main(int argc, char **argv)
#endif /* CONFIG_TASN1 */
#endif /* CONFIG_GNUTLS */
- /* migration_test_add("/migration/ignore_shared", test_ignore_shared); */
+ if (strcmp(arch, "aarch64") == 0) { /* Currently upset on aarch64 TCG */
+ migration_test_add("/migration/ignore_shared", test_ignore_shared);
+ }
+
#ifndef _WIN32
migration_test_add("/migration/precopy/fd/tcp",
test_migrate_precopy_fd_socket);
--
2.43.0
- [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state, (continued)
[RFC PATCH 2/3] tests/qtest/migration-test: enable on s390x, Nicholas Piggin, 2024/05/25
[RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared,
Nicholas Piggin <=
Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests, Thomas Huth, 2024/05/27