Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

[Thomas Huth]

On 02/05/2024 16.57, Eric Blake wrote:
> On Wed, May 01, 2024 at 07:27:46PM +0100, Daniel P. Berrangé wrote:
> > The various targets which define versioned machine types have
> > a bunch of obfuscated macro code for defining unique function
> > and variable names using string concatenation.
> >
> > This addes a couple of helpers to improve the clarity of such
> > code macro.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
...
> > + *  // Normal 2 digit eg 'virt-9.0'
> > + *  #define DEFINE_VIRT_MACHINE(major, minor) \
> > + *      DEFINE_VIRT_MACHINE_IMPL(false, major, minor)
> > + *
> > + *  // Bugfix 3 digit  eg 'virt-9.0.1'
>
> Inconsistent on whether you are using one or two spaces before 'eg'.

While you're at it, maybe also better spell it with dots: e.g.

 Thomas