[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/14] target/s390x: Adjust check of noreturn in translate_one
From: |
Richard Henderson |
Subject: |
[PATCH 13/14] target/s390x: Adjust check of noreturn in translate_one |
Date: |
Wed, 1 May 2024 22:44:16 -0700 |
If help_op is not set, ret == DISAS_NEXT.
Shift the test up from surrounding help_wout, help_cout
to skipping to out, as we do elsewhere in the function.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 7cf2920aec..8e9c0847e3 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -6343,14 +6343,15 @@ static DisasJumpType translate_one(CPUS390XState *env,
DisasContext *s)
}
if (insn->help_op) {
ret = insn->help_op(s, &o);
+ if (ret == DISAS_NORETURN) {
+ goto out;
+ }
}
- if (ret != DISAS_NORETURN) {
- if (insn->help_wout) {
- insn->help_wout(s, &o);
- }
- if (insn->help_cout) {
- insn->help_cout(s, &o);
- }
+ if (insn->help_wout) {
+ insn->help_wout(s, &o);
+ }
+ if (insn->help_cout) {
+ insn->help_cout(s, &o);
}
/* io should be the last instruction in tb when icount is enabled */
--
2.34.1
- [PATCH 02/14] target/s390x: Move cpu_get_tb_cpu_state out of line, (continued)
- [PATCH 02/14] target/s390x: Move cpu_get_tb_cpu_state out of line, Richard Henderson, 2024/05/02
- [PATCH 03/14] target/s390x: Update CR9 bits, Richard Henderson, 2024/05/02
- [PATCH 05/14] target/s390x: Disable conditional branch-to-next for PER, Richard Henderson, 2024/05/02
- [PATCH 10/14] target/s390x: Raise exception from per_store_real, Richard Henderson, 2024/05/02
- [PATCH 11/14] target/s390x: Fix helper_per_ifetch flags, Richard Henderson, 2024/05/02
- [PATCH 13/14] target/s390x: Adjust check of noreturn in translate_one,
Richard Henderson <=
- [PATCH 07/14] target/s390x: Simplify help_branch, Richard Henderson, 2024/05/02
- [PATCH 12/14] target/s390x: Simplify per_ifetch, per_check_exception, Richard Henderson, 2024/05/02
- [PATCH 08/14] target/s390x: Split per_breaking_event from per_branch_*, Richard Henderson, 2024/05/02
- [PATCH 09/14] target/s390x: Raise exception from helper_per_branch, Richard Henderson, 2024/05/02
- [PATCH 14/14] tests/tcg/s390x: Add per.S, Richard Henderson, 2024/05/02
- [PATCH 06/14] target/s390x: Introduce help_goto_indirect, Richard Henderson, 2024/05/02