[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument
From: |
Alex Bennée |
Subject: |
Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument |
Date: |
Tue, 11 Apr 2023 08:31:27 +0100 |
User-agent: |
mu4e 1.10.0; emacs 29.0.90 |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> "hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus).
>
> arm_gic_common_reset_irq_state() calls its second argument
> 'first_cpu', producing a build failure when "hw/core/cpu.h"
> is included:
>
> hw/intc/arm_gic_common.c:238:68: warning: omitting the parameter name in a
> function definition is a C2x extension [-Wc2x-extensions]
> static inline void arm_gic_common_reset_irq_state(GICState *s, int
> first_cpu,
> ^
> include/hw/core/cpu.h:451:26: note: expanded from macro 'first_cpu'
> #define first_cpu QTAILQ_FIRST_RCU(&cpus)
> ^
>
> KISS, rename the function argument.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/intc/arm_gic_common.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c
> index 9702197856..889327a8cf 100644
> --- a/hw/intc/arm_gic_common.c
> +++ b/hw/intc/arm_gic_common.c
> @@ -235,12 +235,13 @@ static void arm_gic_common_realize(DeviceState *dev,
> Error **errp)
> }
> }
>
> -static inline void arm_gic_common_reset_irq_state(GICState *s, int first_cpu,
> +static inline void arm_gic_common_reset_irq_state(GICState *s,
> + int
> first_cpu_index,
I'd have gone for a shorter name like cidx maybe, naming things is hard.
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> int resetprio)
> {
> int i, j;
>
> - for (i = first_cpu; i < first_cpu + s->num_cpu; i++) {
> + for (i = first_cpu_index; i < first_cpu_index + s->num_cpu; i++) {
> if (s->revision == REV_11MPCORE) {
> s->priority_mask[i] = 0xf0;
> } else {
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH 01/10] sysemu/kvm: Remove unused headers, (continued)
- [PATCH 02/10] accel/kvm: Declare kvm_direct_msi_allowed in stubs, Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 03/10] hw/intc/arm_gic: Un-inline GIC*/ITS class_name() helpers, Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument, Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 05/10] hw/arm/sbsa-ref: Include missing 'sysemu/kvm.h' header, Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 06/10] target/arm: Reduce QMP header pressure by not including 'kvm_arm.h', Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 07/10] target/arm: Restrict KVM-specific fields from ArchCPU, Philippe Mathieu-Daudé, 2023/04/05
- [PATCH 08/10] target/ppc: Restrict KVM-specific field from ArchCPU, Philippe Mathieu-Daudé, 2023/04/05