[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 18/27] target/s390x: Disable conditional branch-to-next for PE
From: |
Richard Henderson |
Subject: |
[PATCH v4 18/27] target/s390x: Disable conditional branch-to-next for PER |
Date: |
Mon, 20 Feb 2023 08:40:43 -1000 |
For PER, we require a conditional call to helper_per_branch
for the conditional branch. Fold the remaining optimization
into a call to helper_goto_direct, which will take care of
the remaining gbea adjustment.
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 433703b4c9..6757a0f44f 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -1219,13 +1219,12 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
goto egress;
}
if (is_imm) {
- if (disp == s->ilen) {
- /* Branch to next. */
- per_branch(s, true);
- ret = DISAS_NEXT;
- goto egress;
- }
- if (c->cond == TCG_COND_ALWAYS) {
+ /*
+ * Do not optimize a conditional branch if PER enabled, because we
+ * still need a conditional call to helper_per_branch.
+ */
+ if (c->cond == TCG_COND_ALWAYS
+ || (disp == s->ilen && !per_enabled(s))) {
ret = help_goto_direct(s, disp);
goto egress;
}
--
2.34.1
- [PATCH v4 13/27] target/s390x: Use ilen instead in branches, (continued)
- [PATCH v4 13/27] target/s390x: Use ilen instead in branches, Richard Henderson, 2023/02/20
- [PATCH v4 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2023/02/20
- [PATCH v4 08/27] target/s390x: Introduce gen_psw_addr_disp, Richard Henderson, 2023/02/20
- [PATCH v4 06/27] tests/tcg/s390x: Add sam.S, Richard Henderson, 2023/02/20
- [PATCH v4 15/27] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2023/02/20
- [PATCH v4 16/27] target/s390x: Don't set gbea for user-only, Richard Henderson, 2023/02/20
- [PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2023/02/20
- [PATCH v4 05/27] tests/tcg/s390x: Add bal.S, Richard Henderson, 2023/02/20
- [PATCH v4 01/27] target/s390x: Use tcg_constant_* in local contexts, Richard Henderson, 2023/02/20
- [PATCH v4 09/27] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2023/02/20
- [PATCH v4 18/27] target/s390x: Disable conditional branch-to-next for PER,
Richard Henderson <=
- [PATCH v4 23/27] target/s390x: Remove PER check from use_goto_tb, Richard Henderson, 2023/02/20
- [PATCH v4 10/27] target/s390x: Use gen_psw_addr_disp in pc_to_link_info, Richard Henderson, 2023/02/20
- [PATCH v4 02/27] target/s390x: Use tcg_constant_* for DisasCompare, Richard Henderson, 2023/02/20
- [PATCH v4 12/27] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2023/02/20
- [PATCH v4 20/27] target/s390x: Split per_branch, Richard Henderson, 2023/02/20
- [PATCH v4 17/27] target/s390x: Introduce per_enabled, Richard Henderson, 2023/02/20
- [PATCH v4 24/27] target/s390x: Fix successful-branch PER events, Richard Henderson, 2023/02/20
- [PATCH v4 25/27] tests/tcg/s390x: Add per.S, Richard Henderson, 2023/02/20
- [PATCH v4 22/27] target/s390x: Split per_breaking_event from per_branch_*, Richard Henderson, 2023/02/20
- [PATCH v4 21/27] target/s390x: Simplify help_branch, Richard Henderson, 2023/02/20