Re: [PULL 00/11] Dump patches

[Stefan Hajnoczi]

On Fri, 21 Oct 2022 at 09:37, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6:
>
>   Merge tag 'pull-target-arm-20221020' of 
> https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 
> 14:36:12 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/marcandre.lureau/qemu.git tags/dump-pull-request
>
> for you to fetch changes up to c70f4916a9fc03d70a7d65f4ec59da6c07f1d560:
>
>   dump/win_dump: limit number of processed PRCBs (2022-10-21 16:48:50 +0400)
>
> ----------------------------------------------------------------
> dump queue
>
> Hi
>
> The "dump" queue, with:
> - [PATCH v6/v7 00/10] dump: Add arch section and s390x PV dump
> - [PATCH] dump/win_dump: limit number of processed PRCBs

Please check the following s390 compilation issue:

cc -m64 -mcx16 -Ilibqemu-s390x-softmmu.fa.p -I. -I.. -Itarget/s390x
-I../target/s390x -Iqapi -Itrace -Iui -Iui/shader
-I/usr/include/pixman-1 -I/usr/include/capstone
-I/usr/include/spice-server -I/usr/include/spice-1
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-fdiagnostics-color=auto --coverage -Wall -Winvalid-pch -Werror
-std=gnu11 -O2 -g -isystem /builds/qemu-project/qemu/linux-headers
-isystem linux-headers -iquote . -iquote /builds/qemu-project/qemu
-iquote /builds/qemu-project/qemu/include -iquote
/builds/qemu-project/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common
-fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
-Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined
-Wimplicit-fallthrough=2 -Wno-missing-include-dirs
-Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -p -fPIE
-isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H
'-DCONFIG_TARGET="s390x-softmmu-config-target.h"'
'-DCONFIG_DEVICES="s390x-softmmu-config-devices.h"' -MD -MQ
libqemu-s390x-softmmu.fa.p/target_s390x_arch_dump.c.o -MF
libqemu-s390x-softmmu.fa.p/target_s390x_arch_dump.c.o.d -o
libqemu-s390x-softmmu.fa.p/target_s390x_arch_dump.c.o -c
../target/s390x/arch_dump.c
../target/s390x/arch_dump.c: In function ‘s390x_write_elf64_pv’:
../target/s390x/arch_dump.c:195:5: error: too few arguments to
function ‘kvm_s390_dump_cpu’
195 | kvm_s390_dump_cpu(cpu, &note->contents.dynamic);
| ^~~~~~~~~~~~~~~~~
In file included from ../target/s390x/arch_dump.c:20:
/builds/qemu-project/qemu/include/hw/s390x/pv.h:74:19: note: declared here
74 | static inline int kvm_s390_dump_cpu(S390CPU *cpu, void *buff,
size_t len) { return 0; }
| ^~~~~~~~~~~~~~~~~

https://gitlab.com/qemu-project/qemu/-/jobs/3218295751

Thanks,
Stefan

>
> ----------------------------------------------------------------
>
> Janosch Frank (10):
>   dump: Use a buffer for ELF section data and headers
>   dump: Write ELF section headers right after ELF header
>   dump: Reorder struct DumpState
>   dump: Reintroduce memory_offset and section_offset
>   dump: Add architecture section and section string table support
>   s390x: Add protected dump cap
>   s390x: Introduce PV query interface
>   include/elf.h: add s390x note types
>   s390x: Add KVM PV dump interface
>   s390x: pv: Add dump support
>
> Viktor Prutyanov (1):
>   dump/win_dump: limit number of processed PRCBs
>
>  include/elf.h                |   2 +
>  include/hw/s390x/pv.h        |  19 +++
>  include/sysemu/dump-arch.h   |   3 +
>  include/sysemu/dump.h        |  26 +++-
>  target/s390x/kvm/kvm_s390x.h |   1 +
>  dump/dump.c                  | 288 +++++++++++++++++++++++++++--------
>  dump/win_dump.c              |   7 +
>  hw/s390x/pv.c                | 112 ++++++++++++++
>  hw/s390x/s390-virtio-ccw.c   |   6 +
>  target/s390x/arch_dump.c     | 262 +++++++++++++++++++++++++++----
>  target/s390x/kvm/kvm.c       |   7 +
>  11 files changed, 635 insertions(+), 98 deletions(-)
>
> --
> 2.37.3
>
>