Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState
Date:	Thu, 22 Dec 2022 15:25:39 +0100
User-agent:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 21/12/22 19:22, Daniel Henrique Barboza wrote:

The MachineState object provides a 'fdt' pointer that is already being
used by other RISC-V machines, and it's also used by the 'dumpdtb' QMP
command.

Remove the 'fdt' pointer from SiFiveUState and use MachineState::fdt
instead.

Cc: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
  hw/riscv/sifive_u.c         | 15 ++++++---------
  include/hw/riscv/sifive_u.h |  3 ---
  2 files changed, 6 insertions(+), 12 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test, (continued)
- [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/21
  - Re: [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState, Philippe Mathieu-Daudé, 2022/12/22
    - Re: [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/22
  - Re: [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState, Alistair Francis, 2022/12/22
  - Re: [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState, Bin Meng, 2022/12/23
- [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/21
  - Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState, Philippe Mathieu-Daudé <=
  - Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState, Alistair Francis, 2022/12/22
  - Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState, Bin Meng, 2022/12/23
- [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Daniel Henrique Barboza, 2022/12/21
  - Re: [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Alistair Francis, 2022/12/22
  - Re: [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Bin Meng, 2022/12/23
- [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static, Daniel Henrique Barboza, 2022/12/21
  - Re: [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static, Philippe Mathieu-Daudé, 2022/12/22
  - Re: [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static, Alistair Francis, 2022/12/22
  - Re: [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static, Bin Meng, 2022/12/23
- [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21

Prev by Date: Re: [PATCH 02/15] hw/riscv/spike: use 'fdt' from MachineState
Next by Date: Re: [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static
Previous by thread: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState
Next by thread: Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState
Index(es):
- Date
- Thread