[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include: Don't include qemu/osdep.h
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] include: Don't include qemu/osdep.h |
|
Date: |
Mon, 12 Dec 2022 18:03:45 +0000 |
|
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Mon, Dec 12, 2022 at 04:55:55PM +0000, Taylor Simpson wrote:
>
>
> > -----Original Message-----
> > From: Markus Armbruster <armbru@redhat.com>
> > Sent: Monday, December 12, 2022 1:05 AM
> > To: qemu-devel@nongnu.org
> > Cc: imp@bsdimp.com; kevans@freebsd.org; berrange@redhat.com;
> > jonathan.cameron@huawei.com; kbastian@mail.uni-paderborn.de;
> > jasowang@redhat.com; michael.roth@amd.com; kkostiuk@redhat.com;
> > Taylor Simpson <tsimpson@quicinc.com>; palmer@dabbelt.com;
> > alistair.francis@wdc.com; bin.meng@windriver.com; qemu-
> > riscv@nongnu.org
> > Subject: [PATCH] include: Don't include qemu/osdep.h
> >
> > docs/devel/style.rst mandates:
> >
> > The "qemu/osdep.h" header contains preprocessor macros that affect
> > the behavior of core system headers like <stdint.h>. It must be
> > the first include so that core system headers included by external
> > libraries get the preprocessor macros that QEMU depends on.
> >
> > Do not include "qemu/osdep.h" from header files since the .c file
> > will have already included it.
> >
> > A few violations have crept in. Fix them.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> > bsd-user/qemu.h | 1 -
> > crypto/block-luks-priv.h | 1 -
> > include/hw/cxl/cxl_host.h | 1 -
> > include/hw/input/pl050.h | 1 -
> > include/hw/tricore/triboard.h | 1 -
> > include/qemu/userfaultfd.h | 1 -
> > net/vmnet_int.h | 1 -
> > qga/cutils.h | 1 -
> > target/hexagon/hex_arch_types.h | 1 -
> > target/hexagon/mmvec/macros.h | 1 -
> > target/riscv/pmu.h | 1 -
> > qga/cutils.c | 3 ++-
> > 12 files changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/target/hexagon/hex_arch_types.h
> > b/target/hexagon/hex_arch_types.h index 885f68f760..52a7f2b2f3 100644
> > --- a/target/hexagon/hex_arch_types.h
> > +++ b/target/hexagon/hex_arch_types.h
> > @@ -18,7 +18,6 @@
> > #ifndef HEXAGON_HEX_ARCH_TYPES_H
> > #define HEXAGON_HEX_ARCH_TYPES_H
> >
> > -#include "qemu/osdep.h"
> > #include "mmvec/mmvec.h"
> > #include "qemu/int128.h"
>
> Please change the copyright year in this file from "2019-2021" to "2019-2022".
No, that would be inappropriate.
The Copyright line is attributed to Qualcomm, and Markus doesn't
work for, nor assign copyright to, Qualcomm, so he must not change
the Qualcomm copyright line. Further, merely deleting a line of
code is not a significant change from POV of claiming copyright.
> Otherwise
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|