|
From: | Ben Dooks |
Subject: | Re: add qemu_fdt_setprop_strings |
Date: | Mon, 24 Oct 2022 16:18:42 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 |
On 21/10/2022 08:00, Andrew Jones wrote:
On Fri, Oct 21, 2022 at 06:58:02AM +0100, Ben Dooks wrote:Add a qemu_fdt_setprop_strings to set a string array into a device-tree. Only minor updates from v4 to fix a couple of minor patch issues.Please see the comments I made on patch 1 of the v4 series, they should be addressed. Also, I'm pretty sure I gave r-b's on most, or the rest, of the series, but I don't see those here in v5. And, please CC previous reviewers when sending out new versions. Finally, why not generate this cover letter with git-format-patch?
I'll go back and check the reports, I think I missed the "static const" one. I did completely forget to update the reviewed comments, so will do that and post a V6 this week.
Thanks, drew
-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
[Prev in Thread] | Current Thread | [Next in Thread] |