Re: [PATCH v2 4/6] target/riscv: add support for zdinx

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/6] target/riscv: add support for zdinx

From:	Richard Henderson
Subject:	Re: [PATCH v2 4/6] target/riscv: add support for zdinx
Date:	Fri, 31 Dec 2021 12:07:55 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/30/21 7:23 PM, Weiwei Li wrote:

+    if (reg_num != 0) {
+        switch (get_ol(ctx)) {


get_xl, not get_ol, two instances.

+#ifdef TARGET_RISCV32
+    {
+        TCGv_i64 t = ftemp_new(ctx);
+        tcg_gen_concat_i32_i64(t, cpu_gpr[reg_num], cpu_gpr[reg_num + 1]);
+        return t;
+    }
+#else
+    {
+        TCGv_i64 t = ftemp_new(ctx);
+        tcg_gen_deposit_i64(t, cpu_gpr[reg_num], cpu_gpr[reg_num + 1], 32, 32);
+        return t;
+    }


Unify these two cases and use tcg_gen_concat_tl_i64.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 0/6] support subsets of Float-Point in Integer Registers extensions, Weiwei Li, 2021/12/30
- [PATCH v2 5/6] target/riscv: add support for zhinx/zhinxmin, Weiwei Li, 2021/12/30
  - Re: [PATCH v2 5/6] target/riscv: add support for zhinx/zhinxmin, Richard Henderson, 2021/12/31
- [PATCH v2 1/6] target/riscv: add cfg properties for zfinx, zdinx and zhinx{min}, Weiwei Li, 2021/12/30
  - Re: [PATCH v2 1/6] target/riscv: add cfg properties for zfinx, zdinx and zhinx{min}, Bin Meng, 2021/12/31
- [PATCH v2 4/6] target/riscv: add support for zdinx, Weiwei Li, 2021/12/30
  - Re: [PATCH v2 4/6] target/riscv: add support for zdinx, Richard Henderson <=
- [PATCH v2 3/6] target/riscv: add support for zfinx, Weiwei Li, 2021/12/30
  - Re: [PATCH v2 3/6] target/riscv: add support for zfinx, Richard Henderson, 2021/12/31
  - Re: [PATCH v2 3/6] target/riscv: add support for zfinx, Richard Henderson, 2021/12/31
- [PATCH v2 6/6] target/riscv: expose zfinx, zdinx, zhinx{min} properties, Weiwei Li, 2021/12/30
- [PATCH v2 2/6] target/riscv: hardwire mstatus.FS to zero when enable zfinx, Weiwei Li, 2021/12/30
  - Re: [PATCH v2 2/6] target/riscv: hardwire mstatus.FS to zero when enable zfinx, Richard Henderson, 2021/12/31

Prev by Date: Re: [PATCH v2 3/6] target/riscv: add support for zfinx
Next by Date: Re: [PATCH v2 5/6] target/riscv: add support for zhinx/zhinxmin
Previous by thread: [PATCH v2 4/6] target/riscv: add support for zdinx
Next by thread: [PATCH v2 3/6] target/riscv: add support for zfinx
Index(es):
- Date
- Thread