[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 20/21] target/riscv: Tidy trans_rvh.c.inc
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 20/21] target/riscv: Tidy trans_rvh.c.inc |
|
Date: |
Wed, 18 Aug 2021 00:24:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/17/21 11:18 PM, Richard Henderson wrote:
> Exit early if check_access fails.
> Split out do_hlv, do_hsv, do_hlvx subroutines.
> Use dest_gpr, get_gpr in the new subroutines.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/riscv/insn32.decode | 1 +
> target/riscv/insn_trans/trans_rvh.c.inc | 266 +++++-------------------
> 2 files changed, 57 insertions(+), 210 deletions(-)
Nice diffstat ;)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v2 17/21] target/riscv: Use gen_shift_imm_fn for slli_uw, (continued)
- [PATCH v2 17/21] target/riscv: Use gen_shift_imm_fn for slli_uw, Richard Henderson, 2021/08/17
- [PATCH v2 15/21] target/riscv: Reorg csr instructions, Richard Henderson, 2021/08/17
- [PATCH v2 16/21] target/riscv: Use {get,dest}_gpr for RVA, Richard Henderson, 2021/08/17
- [PATCH v2 18/21] target/riscv: Use {get,dest}_gpr for RVF, Richard Henderson, 2021/08/17
- [PATCH v2 19/21] target/riscv: Use {get,dest}_gpr for RVD, Richard Henderson, 2021/08/17
- [PATCH v2 20/21] target/riscv: Tidy trans_rvh.c.inc, Richard Henderson, 2021/08/17
- Re: [PATCH v2 20/21] target/riscv: Tidy trans_rvh.c.inc,
Philippe Mathieu-Daudé <=
- [PATCH v2 21/21] target/riscv: Use {get,dest}_gpr for RVV, Richard Henderson, 2021/08/17