[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/27] target: Set CPUClass::vmsd instead of DeviceClass::
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v3 01/27] target: Set CPUClass::vmsd instead of DeviceClass::vmsd |
Date: |
Wed, 21 Apr 2021 18:03:33 -0400 |
On Tue, Mar 02, 2021 at 03:57:52PM +0100, Philippe Mathieu-Daudé wrote:
> The cpu model is the single device available in user-mode.
> Since we want to restrict some fields to user-mode emulation,
> we prefer to set the vmsd field of CPUClass, rather than the
> DeviceClass one.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Is this going to have an externally visible effect?
If it does, how can we make sure it's safe?
If it does not, do you know why CPUClass::vmsd exists in the
first place?
Do you think it would be simpler to just squash this patch into
[PATCH v3 08/27] cpu: Move CPUClass::vmsd to SysemuCPUOps
?
--
Eduardo
- Re: [PATCH v3 01/27] target: Set CPUClass::vmsd instead of DeviceClass::vmsd,
Eduardo Habkost <=