[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt
From: |
Asherah Connor |
Subject: |
Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt |
Date: |
Sun, 28 Feb 2021 11:18:06 +0000 |
Hi Bin,
Thanks very much for your review.
On 21/02/28 02:02:p, Bin Meng wrote:
> I guess this is put here because riscv_load_fdt() is trying to touch
> the device tree, and creating fw_cfg has to be done before that?
> Maybe a comment is needed to prevent whoever later wanted to move the
> codes around?
Done!
> > - VIRT_PCIE_ECAM
> > + VIRT_PCIE_ECAM,
> > + VIRT_FW_CFG
>
> nits: insert this before VIRT_FLASH
Done. I've included your Reviewed-by: on the unmodified commit in the
series; I hope this is the correct thing to do.
Best,
Asherah