[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tcg/tcg-op: Fix nonatomic_op load with MO_SIGN
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 1/2] tcg/tcg-op: Fix nonatomic_op load with MO_SIGN |
|
Date: |
Tue, 30 Jun 2020 07:56:10 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/29/20 6:07 AM, LIU Zhiwei wrote:
> @@ -3189,7 +3189,7 @@ static void do_nonatomic_op_i32(TCGv_i32 ret, TCGv
> addr, TCGv_i32 val,
>
> memop = tcg_canonicalize_memop(memop, 0, 0);
>
> - tcg_gen_qemu_ld_i32(t1, addr, idx, memop & ~MO_SIGN);
> + tcg_gen_qemu_ld_i32(t1, addr, idx, memop);
> gen(t2, t1, val);
> tcg_gen_qemu_st_i32(t2, addr, idx, memop);
>
> @@ -3232,7 +3232,7 @@ static void do_nonatomic_op_i64(TCGv_i64 ret, TCGv
> addr, TCGv_i64 val,
>
> memop = tcg_canonicalize_memop(memop, 1, 0);
>
> - tcg_gen_qemu_ld_i64(t1, addr, idx, memop & ~MO_SIGN);
> + tcg_gen_qemu_ld_i64(t1, addr, idx, memop);
> gen(t2, t1, val);
> tcg_gen_qemu_st_i64(t2, addr, idx, memop);
This is insufficient for smin/smax -- we also need to extend the "val" input.
r~