[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile |
Date: |
Wed, 27 Jul 2022 18:09:01 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Wed, Jul 27, 2022 at 01:36:25PM -0300, Lucas Mateus Castro(alqotel) wrote:
> Currently the run script uses 'readlink -e' but the image only has the
> busybox readlink, this commit add the coreutils package which
> contains the readlink with the '-e' option.
Use of 'readlink' is discouraged in favour of 'realpath'. AFAICT, we
can just do that change and not need the '-e' flag anyway.
>
> Signed-off-by: Lucas Mateus Castro(alqotel) <lucas.araujo@eldorado.org.br>
> ---
> tests/docker/dockerfiles/alpine.docker | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/docker/dockerfiles/alpine.docker
> b/tests/docker/dockerfiles/alpine.docker
> index 3f4c0f95cb..2943a99730 100644
> --- a/tests/docker/dockerfiles/alpine.docker
> +++ b/tests/docker/dockerfiles/alpine.docker
> @@ -21,6 +21,7 @@ RUN apk update && \
> cdrkit \
> ceph-dev \
> clang \
> + coreutils \
> ctags \
> curl-dev \
> cyrus-sasl-dev \
This file contents is autogenerated, so editting it manually is
wrong and changes will be lost.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/8] Patch series to set up a ppc64le CI, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 3/8] scripts/ci/setup: Fix libxen requirements, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 1/8] tests/docker: Fix alpine dockerfile, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 2/8] scripts/ci/setup: ninja missing from build-environment, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 5/8] scripts/ci/setup: Add ppc64le to vars.yml template, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 6/8] scripts/ci/setup: Add Fedora to build-environment.yml, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 4/8] scripts/ci/setup: spice-server only on x86 aarch64, Lucas Mateus Castro(alqotel), 2022/07/27
- [PATCH 7/8] scripts/ci/setup: Added debian to build-environment.yml, Lucas Mateus Castro(alqotel), 2022/07/27
- [RFC PATCH 8/8] tests/docker: Selective line reading by python script, Lucas Mateus Castro(alqotel), 2022/07/27