Re: [PATCH RESEND v2 2/2] target/ppc: Implement ISA 3.00 tlbie[l]

[Leandro Lupori]

On 6/24/22 16:50, Richard Henderson wrote:
> On 6/24/22 12:14, Leandro Lupori wrote:
> > This initial version supports the invalidation of one or all
> > TLB entries. Flush by PID/LPID, or based in process/partition
> > scope is not supported, because it would make using the
> > generic QEMU TLB implementation hard. In these cases, all
> > entries are flushed.
> >
> > Signed-off-by: Leandro Lupori <leandro.lupori@eldorado.org.br>
> > ---
> >   target/ppc/helper.h                          |  18 +++
> >   target/ppc/mmu_helper.c                      | 154 +++++++++++++++++++
> >   target/ppc/translate/storage-ctrl-impl.c.inc |  15 ++
> >   3 files changed, 187 insertions(+)
> >
> > diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> > index d627cfe6ed..5e663a0a50 100644
> > --- a/target/ppc/helper.h
> > +++ b/target/ppc/helper.h
> > @@ -672,6 +672,24 @@ DEF_HELPER_FLAGS_1(tlbia, TCG_CALL_NO_RWG, void, 
> > env)
> >   DEF_HELPER_FLAGS_2(tlbie, TCG_CALL_NO_RWG, void, env, tl)
> >   DEF_HELPER_FLAGS_2(tlbiva, TCG_CALL_NO_RWG, void, env, tl)
> >   #if defined(TARGET_PPC64)
> > +
> > +/*
> > + * tlbie[l] helper flags
> > + *
> > + * RIC, PRS, R and local are passed as flags in the last argument.
> > + */
> > +#define TLBIE_F_RIC_SHIFT       0
> > +#define TLBIE_F_PRS_SHIFT       2
> > +#define TLBIE_F_R_SHIFT         3
> > +#define TLBIE_F_LOCAL_SHIFT     4
> > +
> > +#define TLBIE_F_RIC_MASK        (3 << TLBIE_F_RIC_SHIFT)
> > +#define TLBIE_F_PRS             (1 << TLBIE_F_PRS_SHIFT)
> > +#define TLBIE_F_R               (1 << TLBIE_F_R_SHIFT)
> > +#define TLBIE_F_LOCAL           (1 << TLBIE_F_LOCAL_SHIFT)
> > +
>
> Better to put these somewhere else -- internal.h probably -- helper.h is 
> included multiple
> times.

I guess I forgot about this change.
I'll move these defines to another header file.

Thanks,
Leandro

> r~