Re: [PATCH] target/ppc/cpu-models: Update max alias to power10

[Matheus K. Ferst]

On 31/05/2022 14:27, Murilo Opsfelder Araujo wrote:
> Update max alias to power10 so users can take advantage of a more
> recent CPU model when '-cpu max' is provided.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1038
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> ---
>   target/ppc/cpu-models.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 976be5e0d1..c15fcb43a1 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -879,7 +879,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {
>       { "755", "755_v2.8" },
>       { "goldfinger", "755_v2.8" },
>       { "7400", "7400_v2.9" },
> -    { "max", "7400_v2.9" },
>       { "g4",  "7400_v2.9" },
>       { "7410", "7410_v1.4" },
>       { "nitro", "7410_v1.4" },
> @@ -910,6 +909,8 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {
>       { "power8nvl", "power8nvl_v1.0" },
>       { "power9", "power9_v2.0" },
>       { "power10", "power10_v2.0" },
> +    /* Update the 'max' alias to the latest CPU model */
> +    { "max", "power10_v2.0" },
>   #endif
>
>       /* Generic PowerPCs */
> --
> 2.36.1

Hi Murilo,

I guess we need a "max" for qemu-system-ppc too, so maybe something like

>     /* Update the 'max' alias to the latest CPU model */
> #if defined(TARGET_PPC64)
>     { "max", "power10_v2.0" },
> #else
>     { "max", "7457a_v1.2" },
> #endif

Or some other CPU which is considered the max for 32-bit...

Thanks,
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>