Re: [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()

[Mark Cave-Ayland]

On 20/05/2022 19:01, Bernhard Beschow wrote:

> etsec_create() wraps qdev API which is outdated. It is also unused,
> so remove it.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/net/fsl_etsec/etsec.c | 23 -----------------------
>   hw/net/fsl_etsec/etsec.h |  7 -------
>   2 files changed, 30 deletions(-)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 4e6cc708de..b75d8e3dce 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -443,26 +443,3 @@ static void etsec_register_types(void)
>   }
>   
>   type_init(etsec_register_types)
> -
> -DeviceState *etsec_create(hwaddr         base,
> -                          MemoryRegion * mr,
> -                          NICInfo      * nd,
> -                          qemu_irq       tx_irq,
> -                          qemu_irq       rx_irq,
> -                          qemu_irq       err_irq)
> -{
> -    DeviceState *dev;
> -
> -    dev = qdev_new("eTSEC");
> -    qdev_set_nic_properties(dev, nd);
> -    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> -
> -    sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, tx_irq);
> -    sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, rx_irq);
> -    sysbus_connect_irq(SYS_BUS_DEVICE(dev), 2, err_irq);
> -
> -    memory_region_add_subregion(mr, base,
> -                                SYS_BUS_DEVICE(dev)->mmio[0].memory);
> -
> -    return dev;
> -}
> diff --git a/hw/net/fsl_etsec/etsec.h b/hw/net/fsl_etsec/etsec.h
> index fddf551544..3c625c955c 100644
> --- a/hw/net/fsl_etsec/etsec.h
> +++ b/hw/net/fsl_etsec/etsec.h
> @@ -155,13 +155,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(eTSEC, ETSEC_COMMON)
>   #define eTSEC_TRANSMIT 1
>   #define eTSEC_RECEIVE  2
>   
> -DeviceState *etsec_create(hwaddr        base,
> -                          MemoryRegion *mr,
> -                          NICInfo      *nd,
> -                          qemu_irq      tx_irq,
> -                          qemu_irq      rx_irq,
> -                          qemu_irq      err_irq);
> -
>   void etsec_update_irq(eTSEC *etsec);
>   
>   void etsec_walk_tx_ring(eTSEC *etsec, int ring_nbr);

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.