qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 15/21] target/ppc: Remove msr_dr macro


From: Richard Henderson
Subject: Re: [PATCH v3 15/21] target/ppc: Remove msr_dr macro
Date: Tue, 3 May 2022 19:07:40 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 5/3/22 13:24, Víctor Colombo wrote:
msr_dr macro hides the usage of env->msr, which is a bad behavior
Substitute it with FIELD_EX64 calls that explicitly use env->msr
as a parameter.

Suggested-by: Richard Henderson<richard.henderson@linaro.org>
Signed-off-by: Víctor Colombo<victor.colombo@eldorado.org.br>

---

v3: Fix the difference check to use a xor
Signed-off-by: Víctor Colombo<victor.colombo@eldorado.org.br>
---
  target/ppc/cpu.h         |  2 +-
  target/ppc/helper_regs.c |  3 +--
  target/ppc/mmu_common.c  | 10 ++++++----
  3 files changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]