Re: [PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup()

[Laurent Vivier]

Le 03/09/2021 à 19:45, Philippe Mathieu-Daudé a écrit :
> g_memdup() is insecure and as been deprecated in GLib 2.68.
> QEMU provides the safely equivalent g_memdup2() wrapper.
>
> Do not allow more g_memdup() calls in the repository, provide
> a hint to use g_memdup2().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   scripts/checkpatch.pl | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index cb8eff233e0..5caa739db48 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2850,6 +2850,11 @@ sub process {
>                         WARN("consider using g_path_get_$1() in preference to 
> g_strdup($1())\n" . $herecurr);
>                 }
>   
> +# enforce g_memdup2() over g_memdup()
> +               if ($line =~ /\bg_memdup\s*\(/) {
> +                       ERROR("use g_memdup2() instead of unsafe g_memdup()\n" 
> . $herecurr);
> +               }
> +
>   # recommend qemu_strto* over strto* for numeric conversions
>                 if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
>                         ERROR("consider using qemu_$1 in preference to $1\n" . 
> $herecurr);

Applied to my trivial-patches branch.

Thanks,
Laurent