Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

[BALATON Zoltan]

On Fri, 27 Aug 2021, John Arbuckle wrote:
> I was having a problem with missing video resolutions in my Mac OS 9 VM. When I
> ran QEMU it gave no indication as to why these resolutions were missing. I found
> out that the OpenFirmware VGA driver was not being loaded. To prevent anyone 
> from
> going thru the same trouble I went thru I added messages that the user can see
> when a problem takes place with loading this driver in the future.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> hw/ppc/mac_newworld.c | 6 ++++++
> hw/ppc/mac_oldworld.c | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> index 7bb7ac3997..c1960452b8 100644
> --- a/hw/ppc/mac_newworld.c
> +++ b/hw/ppc/mac_newworld.c
> @@ -526,8 +526,14 @@ static void ppc_core99_init(MachineState *machine)
>
>         if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)) {
>             fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, ndrv_size);
> +        } else {
> +            printf("Warning: failed to load driver %s. This may cause video"
> +                   " problems.\n");

I think you should use warn_report for these instead of printf and watch 
out if that needs \n or not (some functions add \n while some others may 
not and I always forget which is which but checkpatch should warn for it 
so you should get nofified if you leave \n there but it's not needed).

Regards,
BALATON Zoltan

>         }
>         g_free(filename);
> +    } else {
> +        printf("Warning: driver %s not found. This may cause video 
> problems.\n",
> +               NDRV_VGA_FILENAME);
>     }
>
>     qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);
> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
> index de2be960e6..96603fe9cf 100644
> --- a/hw/ppc/mac_oldworld.c
> +++ b/hw/ppc/mac_oldworld.c
> @@ -367,8 +367,14 @@ static void ppc_heathrow_init(MachineState *machine)
>
>         if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)) {
>             fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, ndrv_size);
> +        } else {
> +            printf("Warning: failed to load driver %s. This may cause video"
> +                   " problems.\n");
>         }
>         g_free(filename);
> +    } else {
> +        printf("Warning: driver %s not found. This may cause video 
> problems.\n",
> +               NDRV_VGA_FILENAME);
>     }
>
>     qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);