Re: [PATCH] target/ppc: fix single-step exception regression

[Richard Henderson]

On 6/2/21 1:55 AM, David Gibson wrote:
> On Tue, Jun 01, 2021 at 01:27:20PM -0700, Richard Henderson wrote:
> > On 6/1/21 11:02 AM, Luis Pires wrote:
> > > +            if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) {
> > > +                /* We have not updated nip yet, so do it now */
> > > +                gen_update_nip(ctx, nip);
> > > +            }
> >
> > This is incorrect.  Both EXIT and CHAIN *have* updated nip, but to something
> > that isn't the next instruction.  E.g. return from interrupt.
>
> Any theories on what's actually causing the regression, then?

I would have thought the first hunk would have some effect.  But otherwise this 
is the first I've heard of the problem.  Description?  Reproduction instruction?


r~