|
From: | Richard Henderson |
Subject: | Re: [PATCH] target/ppc: fix single-step exception regression |
Date: | Tue, 1 Jun 2021 13:27:20 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 6/1/21 11:02 AM, Luis Pires wrote:
+ if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) { + /* We have not updated nip yet, so do it now */ + gen_update_nip(ctx, nip); + }
This is incorrect. Both EXIT and CHAIN *have* updated nip, but to something that isn't the next instruction. E.g. return from interrupt.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |