[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in
From: |
Richard Henderson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in int_helper.c |
Date: |
Sun, 30 Dec 2018 08:14:25 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/29/18 12:52 AM, Mark Cave-Ayland wrote:
> As pointed out by Richard: it does not need the mask argument, nor does it
> need
> the recast argument. The masking is implied by the cast argument, and the
> recast is implied by the assignment.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> target/ppc/int_helper.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-ppc] [PATCH v2 0/8] target/ppc: remove various endian hacks from int_helper.c, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 8/8] target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in int_helper.c, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 4/8] target/ppc: eliminate use of HI_IDX and LO_IDX macros from int_helper.c, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 7/8] target/ppc: remove ROTRu32 and ROTRu64 macros from int_helper.c, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in int_helper.c, Mark Cave-Ayland, 2018/12/28
- Re: [Qemu-ppc] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in int_helper.c,
Richard Henderson <=
- [Qemu-ppc] [PATCH v2 5/8] target/ppc: eliminate use of EL_IDX macros from int_helper.c, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 3/8] target/ppc: rework vmul{e, o}{s, u}{b, h, w} instructions to use Vsr* macros, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros, Mark Cave-Ayland, 2018/12/28
- [Qemu-ppc] [PATCH v2 1/8] target/ppc: implement complete set of Vsr* macros, Mark Cave-Ayland, 2018/12/28