[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code |
Date: |
Tue, 23 Oct 2018 16:18:59 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Oct 18, 2018 at 05:03:52PM -0300, Eduardo Habkost wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/hppa/dino.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index 564b938e3a..31e09942b5 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -488,17 +488,10 @@ PCIBus *dino_init(MemoryRegion *addr_space,
> return b;
> }
>
> -static int dino_pcihost_init(SysBusDevice *dev)
> -{
> - return 0;
> -}
> -
> static void dino_pcihost_class_init(ObjectClass *klass, void *data)
> {
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> - k->init = dino_pcihost_init;
> dc->vmsd = &vmstate_dino;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PULL 10/45] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init, (continued)
- [Qemu-ppc] [PULL 10/45] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 09/45] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 12/45] hw/mips/gt64xxx_pci: Mark as bridge device, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 13/45] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device', Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code, Eduardo Habkost, 2018/10/18
- Re: [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code,
David Gibson <=
- [Qemu-ppc] [PULL 16/45] hw/mips/malta: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 17/45] machine: fix a typo, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 19/45] memory-device: fix error message when hinted address is too small, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 20/45] memory-device: improve "range conflicts" error message, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 21/45] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 22/45] memory-device: use memory device terminology in error messages, Eduardo Habkost, 2018/10/18