[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v5 02/16] memory-device: fix error message when hinted
From: |
David Hildenbrand |
Subject: |
[Qemu-ppc] [PATCH v5 02/16] memory-device: fix error message when hinted address is too small |
Date: |
Fri, 5 Oct 2018 11:20:10 +0200 |
The "at" should actually be a "before".
if (new_addr < address_space_start)
-> "can't add memory ... before... $address_space_start"
So it looks similar to the other check
} else if ((new_addr + size) > address_space_end)
-> "can't add memory ... beyond..."
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 0b52fe2c5e..7c706fadfc 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -146,7 +146,8 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
const uint64_t *hint,
new_addr = *hint;
if (new_addr < address_space_start) {
error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
- "] at 0x%" PRIx64, new_addr, size, address_space_start);
+ "] before 0x%" PRIx64, new_addr, size,
+ address_space_start);
return 0;
} else if ((new_addr + size) > address_space_end) {
error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
--
2.17.1
- [Qemu-ppc] [PATCH v5 16/16] memory-device: trace when pre_plugging/plugging/unplugging, (continued)
- [Qemu-ppc] [PATCH v5 16/16] memory-device: trace when pre_plugging/plugging/unplugging, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 15/16] memory-device: complete factoring out unplug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 14/16] memory-device: complete factoring out plug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 12/16] memory-device: add device class function set_addr(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 10/16] memory-device: factor out get_memory_region() from pc-dimm, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 11/16] memory-device: drop get_region_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 13/16] memory-device: complete factoring out pre_plug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 08/16] memory-device: document MemoryDeviceClass, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 09/16] memory-device: add and use memory_device_get_region_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 04/16] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 02/16] memory-device: fix error message when hinted address is too small,
David Hildenbrand <=
- [Qemu-ppc] [PATCH v5 03/16] memory-device: improve "range conflicts" error message, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 07/16] memory-device: forward errors in get_region_size()/get_plugged_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 05/16] memory-device: use memory device terminology in error messages, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 06/16] memory-device: introduce separate config option, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 01/16] memory-device: fix alignment error message, David Hildenbrand, 2018/10/05
- Re: [Qemu-ppc] [PATCH v5 00/16] memory-device: complete refactoring, David Hildenbrand, 2018/10/09