[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type |
Date: |
Thu, 20 Sep 2018 13:13:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/20/18 12:31 PM, Roman Kapl wrote:
>> Given that the previous (broken) version of this patch is already
>> queued in
>> ppc-for-3.1, would it be better to send a v2 whereby these changes are
>> squashed into
>> the original?
>>
>
> I don't know if David Gibson will want to modify history in his branch
> -- maybe other people depend on it?
>
> And anyway, Phillipe wants it even more granular.
>
> I don't have any strong opinions about it, David can either squash it or
> tell me to split it, I just need some consensus. I thought that
> splitting this was overdoing it a bit and does not have that many
> advantages given how close the commits are.
> Fixes: ea8073c10d ("target/ppc: add external PID support")
Your previous patch is now d12a22c5c7 in David Gibson's tree, so I think
here squashing your fixes (once this patch got reviewed) is the best option.
Regards,
Phil.
- [Qemu-ppc] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Roman Kapl, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Philippe Mathieu-Daudé, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Mark Cave-Ayland, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Roman Kapl, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type,
Philippe Mathieu-Daudé <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Roman Kapl, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, David Gibson, 2018/09/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, David Gibson, 2018/09/20
Re: [Qemu-ppc] [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type, Peter Maydell, 2018/09/20