[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v3 19/22] hmp: handle virtio-pmem when printing memory
From: |
David Hildenbrand |
Subject: |
[Qemu-ppc] [PATCH v3 19/22] hmp: handle virtio-pmem when printing memory device infos |
Date: |
Thu, 20 Sep 2018 12:32:40 +0200 |
Print the memory device info just like for PCDIMM/NVDIMM.
Signed-off-by: David Hildenbrand <address@hidden>
---
hmp.c | 29 +++++++++++++++++------------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/hmp.c b/hmp.c
index 4975fa56b0..a592a4af9d 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2529,27 +2529,21 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
*qdict)
MemoryDeviceInfoList *info_list = qmp_query_memory_devices(&err);
MemoryDeviceInfoList *info;
MemoryDeviceInfo *value;
- PCDIMMDeviceInfo *di;
+ VirtioPMemDeviceInfo *vpi;
for (info = info_list; info; info = info->next) {
+ PCDIMMDeviceInfo *di = NULL;
+
value = info->value;
if (value) {
switch (value->type) {
case MEMORY_DEVICE_INFO_KIND_DIMM:
di = value->u.dimm.data;
- break;
-
case MEMORY_DEVICE_INFO_KIND_NVDIMM:
- di = value->u.nvdimm.data;
- break;
-
- default:
- di = NULL;
- break;
- }
-
- if (di) {
+ if (!di) {
+ di = value->u.nvdimm.data;
+ }
monitor_printf(mon, "Memory device [%s]: \"%s\"\n",
MemoryDeviceInfoKind_str(value->type),
di->id ? di->id : "");
@@ -2562,6 +2556,17 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
*qdict)
di->hotplugged ? "true" : "false");
monitor_printf(mon, " hotpluggable: %s\n",
di->hotpluggable ? "true" : "false");
+ break;
+ case MEMORY_DEVICE_INFO_KIND_VIRTIO_PMEM:
+ vpi = value->u.virtio_pmem.data;
+ monitor_printf(mon, "Memory device [%s]: \"%s\"\n",
+ MemoryDeviceInfoKind_str(value->type),
+ vpi->id ? vpi->id : "");
+ monitor_printf(mon, " memaddr: 0x%" PRIx64 "\n",
vpi->memaddr);
+ monitor_printf(mon, " size: %" PRIu64 "\n", vpi->size);
+ monitor_printf(mon, " memdev: %s\n", vpi->memdev);
+ default:
+ break;
}
}
}
--
2.17.1
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, (continued)
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Pankaj Gupta, 2018/09/21
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Markus Armbruster, 2018/09/21
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Hildenbrand, 2018/09/21
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Markus Armbruster, 2018/09/21
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Hildenbrand, 2018/09/21
Re: [Qemu-ppc] [PATCH v3 17/22] virtio-pmem: prototype, David Gibson, 2018/09/24
[Qemu-ppc] [PATCH v3 18/22] virtio-pci: proxy for virtio-pmem, David Hildenbrand, 2018/09/20
[Qemu-ppc] [PATCH v3 19/22] hmp: handle virtio-pmem when printing memory device infos,
David Hildenbrand <=
[Qemu-ppc] [PATCH v3 20/22] numa: handle virtio-pmem in NUMA stats, David Hildenbrand, 2018/09/20
[Qemu-ppc] [PATCH v3 21/22] virtio-pmem: hotplug support functions, David Hildenbrand, 2018/09/20
[Qemu-ppc] [PATCH v3 22/22] pc: support for virtio-pmem, David Hildenbrand, 2018/09/20