[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads)
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads) |
Date: |
Mon, 12 Feb 2018 14:40:47 +1100 |
From: Laurent Vivier <address@hidden>
We ignore silently the value of smp_threads when we set
the default VSMT value, and if smp_threads is greater than VSMT
kernel is going into trouble later.
Fixes: 8904e5a750
("spapr: Adjust default VSMT value for better migration compatibility")
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 96515036e6..9f29434819 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2310,7 +2310,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *spapr,
Error **errp)
* the value that we'd get with KVM on POWER8, the
* overwhelmingly common case in production systems.
*/
- spapr->vsmt = 8;
+ spapr->vsmt = MAX(8, smp_threads);
}
/* KVM: If necessary, set the SMT mode: */
--
2.14.3
- [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180212, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 02/12] hw/ppc: rename functions in comments, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 01/12] spapr: add missing break in h_get_cpu_characteristics(), David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads),
David Gibson <=
- [Qemu-ppc] [PULL 08/12] cuda: minor cosmetic tidy-ups to get_next_irq_time(), David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 03/12] cuda: do not use old_mmio accesses, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 09/12] cuda: don't call cuda_update() when writing to ACR register, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 11/12] cuda: factor out timebase-derived counter value and load time, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 06/12] cuda: introduce CUDAState parameter to get_counter(), David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 07/12] cuda: rename frequency property to tb_frequency, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 04/12] cuda: don't allow writes to port output pins, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 10/12] cuda: set timer 1 frequency property to CUDA_TIMER_FREQ, David Gibson, 2018/02/11
- [Qemu-ppc] [PULL 12/12] misc: introduce new mos6522 VIA device and enable it for ppc builds, David Gibson, 2018/02/11
- Re: [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180212, Peter Maydell, 2018/02/12