Re: [Qemu-ppc] [PATCHv3 4/5] pseries: Enable HPT resizing for 2.9

[Suraj Jitindar Singh]

On Wed, 2016-12-14 at 17:20 +1100, David Gibson wrote:
> On Wed, Dec 14, 2016 at 04:32:26PM +1100, Suraj Jitindar Singh wrote:
> > 
> > On Mon, 2016-12-12 at 15:06 +1100, David Gibson wrote:
> > > 
> > > We've now implemented a PAPR extensions which allows PAPR guests
> > > (i.e.
> > > "pseries" machine type) to resize their hash page table during
> > > runtime.
> > > 
> > > However, that extension is only enabled if explicitly chosen on
> > > the
> > > command line.  This patch enables it by default for spapr-2.9,
> > > but
> > > leaves
> > > it disabled (by default) for older machine types.
> > > 
> > > Signed-off-by: David Gibson <address@hidden>
> > > Reviewed-by: Laurent Vivier <address@hidden>
> > > ---
> > >  hw/ppc/spapr.c | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > > index d057031..f05d0e5 100644
> > > --- a/hw/ppc/spapr.c
> > > +++ b/hw/ppc/spapr.c
> > > @@ -2779,7 +2779,7 @@ static void
> > > spapr_machine_class_init(ObjectClass *oc, void *data)
> > >  
> > >      smc->dr_lmb_enabled = true;
> > >      smc->tcg_default_cpu = "POWER8";
> > > -    smc->resize_hpt_default = SPAPR_RESIZE_HPT_DISABLED;
> > > +    smc->resize_hpt_default = SPAPR_RESIZE_HPT_ENABLED;
> > >      mc->query_hotpluggable_cpus = spapr_query_hotpluggable_cpus;
> > >      fwc->get_dev_path = spapr_get_fw_dev_path;
> > >      nc->nmi_monitor_handler = spapr_nmi;
> > > @@ -2860,8 +2860,11 @@ static void
> > > spapr_machine_2_8_instance_options(MachineState *machine)
> > >  
> > >  static void spapr_machine_2_8_class_options(MachineClass *mc)
> > >  {
> > > +    sPAPRMachineClass *smc = SPAPR_MACHINE_CLASS(mc);
> > > +
> > >      spapr_machine_2_9_class_options(mc);
> > >      SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_8);
> > > +    smc->resize_hpt_default = SPAPR_RESIZE_HPT_DISABLED;
> > >  }
> > >  
> > >  DEFINE_SPAPR_MACHINE(2_8, "2.8", false);
> > If people don't want this by default they should probably specify
> > on
> > the command line.
> Uh.. I don't follow you.
Just agreeing with you setting the default to enabled :)
> 
> > 
> > Reviewed-by: Suraj Jitindar Singh <address@hidden>
> >