[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCHv3 4/5] pseries: Enable HPT resizing for 2.9
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCHv3 4/5] pseries: Enable HPT resizing for 2.9 |
Date: |
Wed, 14 Dec 2016 17:20:44 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Dec 14, 2016 at 04:32:26PM +1100, Suraj Jitindar Singh wrote:
> On Mon, 2016-12-12 at 15:06 +1100, David Gibson wrote:
> > We've now implemented a PAPR extensions which allows PAPR guests
> > (i.e.
> > "pseries" machine type) to resize their hash page table during
> > runtime.
> >
> > However, that extension is only enabled if explicitly chosen on the
> > command line. This patch enables it by default for spapr-2.9, but
> > leaves
> > it disabled (by default) for older machine types.
> >
> > Signed-off-by: David Gibson <address@hidden>
> > Reviewed-by: Laurent Vivier <address@hidden>
> > ---
> > hw/ppc/spapr.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index d057031..f05d0e5 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -2779,7 +2779,7 @@ static void
> > spapr_machine_class_init(ObjectClass *oc, void *data)
> >
> > smc->dr_lmb_enabled = true;
> > smc->tcg_default_cpu = "POWER8";
> > - smc->resize_hpt_default = SPAPR_RESIZE_HPT_DISABLED;
> > + smc->resize_hpt_default = SPAPR_RESIZE_HPT_ENABLED;
> > mc->query_hotpluggable_cpus = spapr_query_hotpluggable_cpus;
> > fwc->get_dev_path = spapr_get_fw_dev_path;
> > nc->nmi_monitor_handler = spapr_nmi;
> > @@ -2860,8 +2860,11 @@ static void
> > spapr_machine_2_8_instance_options(MachineState *machine)
> >
> > static void spapr_machine_2_8_class_options(MachineClass *mc)
> > {
> > + sPAPRMachineClass *smc = SPAPR_MACHINE_CLASS(mc);
> > +
> > spapr_machine_2_9_class_options(mc);
> > SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_8);
> > + smc->resize_hpt_default = SPAPR_RESIZE_HPT_DISABLED;
> > }
> >
> > DEFINE_SPAPR_MACHINE(2_8, "2.8", false);
> If people don't want this by default they should probably specify on
> the command line.
Uh.. I don't follow you.
> Reviewed-by: Suraj Jitindar Singh <address@hidden>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCHv3 5/5] pseries: Use smaller default hash page tables when guest can resize, (continued)