Re: [Qemu-ppc] [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

[Benjamin Herrenschmidt]

On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote:
> 
> > > 
> > > total: 428 errors, 73 warnings, 1950 lines checked
> > > 
> > > Your patch has style problems, please review.If any of these
> > > errors
> > > are false positives report them to the maintainer, see
> > > CHECKPATCH in MAINTAINERS.
> 
> It seems very unlikely all of the reported errors here can be
> justified
> along the lines of internal consistency, especially for adding a new
> file.

It's actually an old thread ;-) I've already fixed some of these, just
haven't had a chance to finish and submit a new version.

However *most* of the above are intentional and I won't fix, it's about
the .h file describing the registers that is essentially lifted from
Linux and that I want to keep largely identical for obvious reasons
(thus including the use of tabs).

Cheers,
Ben.