Re: [Qemu-ppc] [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine

[Cédric Le Goater]

On 09/14/2016 04:33 PM, Cédric Le Goater wrote:
> On 09/14/2016 03:59 PM, Alex Bennée wrote:
>>
>> David Gibson <address@hidden> writes:
>>
>>> From: Cédric Le Goater <address@hidden>
>>>
>>> The exact same routine will be used in PowerNV.
>>>
>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>> Signed-off-by: David Gibson <address@hidden>
>>
>> This patch has broken 32 bit x86 builds on CentOS6 (I happened to be looking
>> at something else and found it broken):
>>
>>     14:57 address@hidden/i686  [qemu.git/bisect:???] >make
>>       CC    ppc-softmmu/hw/ppc/fdt.o
>>     In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
>>     /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of 
>> typedef ‘CPUPPCState’
>>     /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous 
>> declaration of ‘CPUPPCState’ was here
>>     make[1]: *** [hw/ppc/fdt.o] Error 1
>>     make: *** [subdir-ppc-softmmu] Error 2
> 
> ok. CentOS6 must be 4.4 compiler, which has that kind of problem.
> 
> Could you try that quick fix ?

Nah, Paolo did it already :)

Thanks ! 

C.