[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [FIX v1 PATCH] spapr_rtas: Prevent QEMU crash during hotp
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [FIX v1 PATCH] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add |
Date: |
Tue, 1 Sep 2015 09:55:05 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 31, 2015 at 11:08:13AM +0530, Bharata B Rao wrote:
> If drmgr is used in the guest to hotplug a device before a device_add
> has been issued via the QEMU monitor, QEMU segfaults in configure_connector
> call. This occurs due to accessing of NULL FDT which otherwise would have
> been created and associated with the DRC during device_add command.
>
> Check for NULL FDT and return failure from configure_connector call.
> As per PAPR+, an error value of -9003 seems appropriate for this failure.
>
> Signed-off-by: Bharata B Rao <address@hidden>
> Cc: Michael Roth <address@hidden>
Applied to spapr-next, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpIK_gz48zpj.pgp
Description: PGP signature