[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] mac_dbdma: always clear FLUSH bit once DBDMA chan
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-ppc] [PATCH] mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete |
|
Date: |
Sun, 23 Aug 2015 22:24:58 -0700 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 23.08.15 03:50, Mark Cave-Ayland wrote:
> The code to flush the DBDMA channel was effectively duplicated in
> dbdma_control_write(), except for the fact that the copy executed outside of a
> RUN bit transition was broken by not clearing the FLUSH bit once the flush was
> complete.
>
> Newer PPC Linux kernels would timeout waiting for the FLUSH bit to clear again
> after submitting a FLUSH command. Fix this by always clearing the FLUSH bit
> once the channel flush is complete and removing the repeated code.
>
> Reported-by: Aurelien Jarno <address@hidden>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Aurelien Jarno <address@hidden>
Thanks, applied to ppc-next.
Alex