[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [RFC PATCH v0 5/5] spapr: Move memory hotplug to RTAS_LOG_V6_
From: |
Bharata B Rao |
Subject: |
[Qemu-ppc] [RFC PATCH v0 5/5] spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type |
Date: |
Mon, 3 Aug 2015 11:05:43 +0530 |
Till now memory hotplug used RTAS_LOG_V6_HP_ID_DRC_INDEX hotplug type
which meant that we generated one hotplug type of EPOW event for every
256MB (SPAPR_MEMORY_BLOCK_SIZE). This quickly overruns the kernel
rtas log buffer thus resulting in loss of memory hotplug events. Switch
to RTAS_LOG_V6_HP_ID_DRC_COUNT hotplug type for memory so that we
generate only one event per hotplug request.
Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 13af9be..2426345 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2072,9 +2072,9 @@ static void spapr_add_lmbs(DeviceState *dev, uint64_t
addr, uint64_t size,
drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
drck->attach(drc, dev, fdt, fdt_offset, !dev->hotplugged, errp);
- spapr_hotplug_req_add_by_index(drc);
addr += SPAPR_MEMORY_BLOCK_SIZE;
}
+ spapr_hotplug_req_add_by_count(SPAPR_DR_CONNECTOR_TYPE_LMB, nr_lmbs);
}
static void spapr_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
--
2.1.0
- [Qemu-ppc] [RFC PATCH v0 0/5] spapr-next: Memory hotplug updates, Bharata B Rao, 2015/08/03
- [Qemu-ppc] [RFC PATCH v0 1/5] spapr: Provide better error message when slots exceed max allowed, Bharata B Rao, 2015/08/03
- [Qemu-ppc] [RFC PATCH v0 5/5] spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type,
Bharata B Rao <=
- [Qemu-ppc] [RFC PATCH v0 2/5] spapr: Populate ibm, associativity-lookup-arrays correctly for non-NUMA, Bharata B Rao, 2015/08/03
- [Qemu-ppc] [RFC PATCH v0 3/5] spapr: Revert to address@hidden representation for non-hotplugged memory, Bharata B Rao, 2015/08/03
- [Qemu-ppc] [RFC PATCH v0 4/5] spapr: Support hotplug by specifying DRC count, Bharata B Rao, 2015/08/03
Re: [Qemu-ppc] [RFC PATCH v0 0/5] spapr-next: Memory hotplug updates, David Gibson, 2015/08/11